update parameters in Job functions
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnacioHeredia
changed the title
deregister_job()Job functions
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 90.63% 90.71% +0.08%
==========================================
Files 31 31
Lines 1292 1293 +1
==========================================
+ Hits 1171 1173 +2
+ Misses 121 120 -1
|
|
@IgnacioHeredia Could you, please, fix the linters? |
|
@nikita-b done! |
|
LGTM, @IgnacioHeredia thanks for your contribution! |
nikita-b
approved these changes
Jun 1, 2023
|
@IgnacioHeredia Oh, it seems we still have an issue with |
|
@nikita-b done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little update on the parameters in
deregister_job(). Tested it.I choose
Unioninstead ofOptionalfor parameters in line with this.